Lowering vectorized pad #3261
Draft
Lowering vectorized pad #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d0addc4.
|
!build |
|
!build |
jjsjann123
commented
Oct 23, 2024
| @@ -1001,6 +1001,94 @@ class CudaKernelGenerator : private kir::ConstIrVisitor { | |||
| } | |||
|
|
|||
| void handle(const TernaryOp* top) final { | |||
| // Get vectorization information | |||
There was a problem hiding this comment.
Note for myself. merge this with LoadStoreOp
jjsjann123
commented
Oct 23, 2024
| @@ -2306,9 +2306,22 @@ void IndexLowering::handle(const PadOp* pad) { | |||
|
|
|||
| pred = GpuLower::current()->commonScalarMap().hoistScalar(pred, for_loops_); | |||
|
|
|||
| #if 0 | |||
| const auto prev_scope = active_scope_; | |||
There was a problem hiding this comment.
remove commented code and open an issue to track this as alternative for when we needed to lift the ternary into an if statement later.
|
🥳 for green CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smoke test